[MPlayer-dev-eng] (yet) another batch of compiler warning fixes

[Felix Buenemann]

On Thursday 11 July 2002 23:52, Dominik Mierzejewski wrote:
> On Thursday, 11 July 2002, Felix Buenemann wrote:
> > On Wednesday 10 July 2002 21:02, Joey Parrish wrote:
> > > On Wed, Jul 10, 2002 at 11:14:40AM +0200, Dominik Mierzejewski wrote:
> > > > They're still not applied, but nobody said they were bad last time
> > > > I sent them.
> > >
> > > There's only one problem that I see, and that's that this hunk:
> > >
> > > -typedef unsigned long ulong;
> > > +/* typedef unsigned long ulong; */ /* already defined in
> > > <sys/types.h>, which is included by <stdlib.h> */
> > >
> > > causes problems on cygwin.  Under cygwin, ulong is never defined
> > > in any standard headers.  I suggest something like this:
> > >
> > > +#if defined(__CYGWIN__)
> > >  typedef unsigned long ulong;
> > > +#endif
> > >
> > > and if there are any other systems that have no ulong def, then
> > > they can be added to the #if defined line.
> >
> > if it only affect cygwin, it could be added to the cygwin_inttypes.h
> > file.
>
> My pal confirms it also affects DJGPP. I don't know if mplayer compiles
> under DOS/DJGPP, but we'll try it :->> At least we could try to get VESA
> and SVGAlib working.
Please use my recommended way and replace those ulong by unsigned long all 
over that file and remove the typedef, IMHO there is no sense of using such 
non-standard shortcuts.
-- 
Best Regards,
        Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________