[MPlayer-dev-eng] machine lockup due to xv driver

[Nilmoni Deb]

pl,
	I have already tried a hack. I re-enabled the set_video_eq
function call in mplayer.c (v1.528), but commented out the blocks for
saturation and contrast in the set_video_eq function definition. Still, I
got the lockup.

Also, as I have said already, the _only_ thing that triggers the lockup is
the set_video_eq function call in mplayer.c (v1.528). The vo_xv.c (v1.105)
works just fine. So I think my initial guess about wrong values of xv
attributes being the cause of lockup may be wrong.

Can somebody explain what the function set_video_eq in mplayer.c does ?
Just explain the lines in any one block such as:

 mp_cmd = (mp_cmd_t *)calloc( 1,sizeof( *mp_cmd ) );
  mp_cmd->id=MP_CMD_BRIGHTNESS; mp_cmd->name=strdup( "brightness" );
  mp_cmd->args[0].v.i=vo_gamma_brightness; mp_cmd->args[1].v.i=1;
mp_input_queue_cmd( mp_cmd );


thanks
- Nil


> It is a problem. I reported the bug on the -cvs mailing list as it was
> triggered with nvidia drivers. Pontscho commited a quick workaround for
> nvidia but the initialization does not seem fixed :/
>
> You might try replacing in libvo/vo_xv.c:
>                     if(!port_value && use_reset) continue
> by a
>                     if(port_value < -100 || port_value > 100) continue;
> 
> This should prevent out of range values from being sent to your xv
> driver
> which should ignore them instead of crashing.
>
> -- 
> Best regards,
>   pl