[MPlayer-dev-eng] [patch] removing va_arg from control functions, equalizer fix
Jindrich Makovicka
makovick at kmlinux.fjfi.cvut.cz
Sun Jul 28 11:00:38 CEST 2002
This patch removes all the ...'s from "control" functions in vo,vf and
vd's. IMO passing all the parameters in the data argument would be much
cleaner way. For equalizer control, I added the structures which allow
passing all the parameters via a pointer. This also fixes a segfault
when using the EQ because the parameters are passed through about four
functions and one of them drops the all the variable arguments. With the
variable args, the fix would require checking for the type of the
parameters on every stage, which is extremely cumbersome and error-prone.
The patch is fairly long because it changes a lot of files, but the
changes are only seldom longer than one line.
--
Jindrich Makovicka
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: control.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20020728/f968170e/attachment.asc>
More information about the MPlayer-dev-eng
mailing list