[MPlayer-dev-eng] [PATCH] Activating/Deactivating of XScreenSaver

[Arpi]

Hi,

> xscreensaver gets stopped and restarted after mplayer quits.  If I do
> a 'killall -9 mplayer' xscreensaver does not get restarted, though.

yes

> Ideally mplayer should only pause xscreensaver, see the xscreensaver
> FAQ:
> 
> http://www.jwz.org/xscreensaver/faq.html#dvd

yes, a very ugly & unacceptable way...

> Since xscreensaver is used for locking the screen, a crashing mplayer
why? if it crashes, it calls vo's uninit (and all uninit stuff) before
exiting

> can be a security hole, because the screen will not be locked again
> and the user is probably not aware of this.
imho if an user executes killall -9 mplayer, he will notice it...
of couse it's possible if he has wireless keyboard & mouse, and his
neightbour executes killall with a compatible key+mouse pair...

> This is my pet peeve, too, and a very nice feature, I believe.  Movie
> players should disable screensavers.

and screensavers should provide an acceptable interface for disabling
screensaver.

running shell command every 10 sec by the movie player to keep the
screensaver disabled is not acceptable, at least by me.

and, it's exploittable too, if the neighbour sets alias rm -rf / to
xscreensaver-command :)

imho, if the screensaver really wants a way to detect kill -9'ed program,
then do the disabling via a socket (local port or named pipe, doesn't
matter). the app should open it, and while it's open, the screensaver
shouldn't blank. if teh app dies, the kernel will close it.

or even simpler: just attach and use the standard X11 way of disabling
screensaver. or use inter-window X11 events or properties (same as used by
drag'n'drop, dockapps etc) to receive the 'ping' from the app.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu