[MPlayer-dev-eng] Another set of compiler warning fixes

Dominik Mierzejewski dominik at rangers.eu.org
Sat Jun 22 15:15:35 CEST 2002


On Saturday, 22 June 2002, Arpi wrote:
> Hi,
Hi,
 
> > Looks like most of my fixes were applied to CVS recently.
> > However, few are still missing. Apply at your own discretion.
> 
> >  
> > +void uninit_audio(sh_audio_t *sh_audio);	/* forward declaration */
> > +
> 
> it's defined in dec_audio.h (not in .c)

Right. Looks like an old leftover. Removed.

> > +++ MPlayer-20020618/libmpcodecs/vd.c	Tue Jun 18 19:51:31 2002
> > @@ -23,6 +23,8 @@
> >  #include "vd.h"
> >  #include "vf.h"
> >  
> > +#include "dec_video.h"
> > +
> 
> why does vd.c needs it? it shouldn't!

Probably a leftover as well. Removed.

> > +++ MPlayer-20020618/libmpcodecs/mp_image.h	Tue Jun 18 19:51:31 2002
> > @@ -1,6 +1,8 @@
> >  #ifndef __MP_IMAGE_H
> >  #define __MP_IMAGE_H 1
> >  
> > +#include <string.h>
> > +
> 
> NEVER include headers from headers
> (and get .so to understand this...)

Right. Removed.
 
> >  
> > -typedef unsigned long ulong;
> > +/* typedef unsigned long ulong; */ /* already defined in <sys/types.h>, which is included by 
> <s
> > tdlib.h> */
> 
> on every supported platforms?

I don't know. I don't have access to anything other than Linux.
Can someone check this?

Thanks.
 
-- 
MPlayer RPMs: http://msp-190.man.olsztyn.pl/~dominik/linux/pkgs/mplayer/
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"
Dominik 'Rathann' Mierzejewski <rathann(at)rangers.eu.org>



More information about the MPlayer-dev-eng mailing list