[MPlayer-dev-eng] ao_alsa9 cleanup
Alex Beregszaszi
alex at naxine.org
Wed Jun 26 20:09:20 CEST 2002
Hi,
[snip]
> +
> +#define buffertime /* last undef */
> +#undef set_period /* only function now is to set chunksize staticaly, last defined */
> +#define sw_params /* last undef */
could you change all these defines to uppercase? it was a failure by me
to write them lowercase (i really dont wanted to commit that alpha code, but..
it happened so ;)
[snip]
> /* how many byes are free in the buffer */
> static int get_space()
> {
> @@ -690,7 +736,9 @@
>
> snd_pcm_status_free(status);
>
> - if (ret < 0)
> + if (ret < 0) {
> +
> ret = 0;
> return(ret);
> + }
> }
this change to get_space is bad !
ret is set always to something, to a real value, to zero or possible
to minus by errors. libao2 api didn't likes negative numbers in get_space
Have you tested this patch only on beta12/rc2? Could you test it on
older 0.9.0 versions?
And thanks for your work!
-
alex
More information about the MPlayer-dev-eng
mailing list