[MPlayer-dev-eng] ao_alsa9 cleanup

Alex Beregszaszi alex at naxine.org
Fri Jun 28 18:41:00 CEST 2002


Hi,

> > > i currently changed now also some malloc's to alloca and added an undef of alsa_device in uninit, cause this was a problem with the gui.
> > does this malloc->alloca change has advantages?
> 
> not really but its easyier to use i think. for example you dont have to check if alsa_device is defined and free it. and currently there is a mix of allocas and mallocs and i thought it would be better to choose one style where possible and don't mix it wildly. but its maybe an 'aesthetic' choice.
ok, than it's useful

> > > the next step would be to implement controls, i just tried but you know the alsa-documentation...
> > controls? libao2 controls: set_volume/get_volume? or alsa-controls?
> 
> set_volumen/get_volume
OK, do it, it will be nice.

Anyway, I applied your patch today.

-
alex



More information about the MPlayer-dev-eng mailing list