[MPlayer-dev-eng] libmpcodec and strides

[Arpi]

Hi,

> Which stuff should determine possibility of DR usage: libmpcodec or libvo?
vd_*.c files set flags they support (like ACCEPT_STRIDE etc) and
requirements they need (like READABLE, PRESERVE).
then vd.c will call get_image() of libvo's control(), passing this mpi
struct. the libvo driver can check if it can provide such buffer, then it
sets stride + pointers and set DIRECT flag.
this works fine with mga, xmga and xv drivers.

> Current implementation of libpcodec doesn't check this fact but old
> dec_video did that?
old dec_video didn't support DR at all.
(except your hack but it worked only for width%16==0 and vidix)

> In short: 405.avi with vidix+DR+dshow doesn't display correctly.
> 
> Indeed I can fix that within of vosub_vidix but before it was detected only 
> once
> within init_video_vaa() function. If it should be implemented in libvo drive
> r then
> those unnecessary compting will be performed for each frame.
?


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu