[MPlayer-dev-eng] about libvo... IMPORTANT

[Arpi]

Hi,

> > So, the flow of libvo calls _NOW_:
> > 
> > 1. preinit() - once before all other calls
> > 2. control() calls, especialy query_format()
> > 3. config() - 0, 1, 2 or more times called
> 
> What is config supposed to return? Most (all?) libvo drivers seems to assume
> that -1 is a failure and 0 is success. libmpcodecs seems to assume that 0 is
>  a
> failure and anything else is success.

yes, it's a design issue...
0=fail 1=ok everywhere except libvo...

> When is config called zero times? And when is it called more than once? When
zero: when the codec fails.
1. preinit
2. "handshaking" between codec, filters and libvo (calls to libvo's
control() to get supported colorspaces etc). if it fails then libvo will
be uninit-ed and jump to next file.
3. config
4. draw* + flip_page (decoding)
5. uninit

> several files are played the order seems to be preinit, config, uninit,
> (preinit?), config, ...
currently. it will be extended, so if multiple file splayed with the same
-vo, and -cache is disabled, it won't uninit and re-init libvo for next file.
now it crashes most vo drivers, so they must be fixed first.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu