[MPlayer-dev-eng] MP3 demuxing is too slow

[Arpi]

Hi,

> > **ARGH**
>  
> > I've already explained when you first complained to demuxer...
>  
> > your profiling is simply bad.
> 
> It's not.

it is.

> > it counts the code running at detection pass too.
> 
> Seems you have no idea how gprof works.

yes.
but i doubt (really) that it can make difference between demux code used
only at detection and demux code used for real demuxing...

> > if you at least thinking, you'll see that demux_mpg_fill_buffer is NOT par
> t
> > of mp3 playback, it's used by mpeg _video_ file demuxer.
> 
> Right. Guess what: it's really using the video multiplexer, moving the
> MPEG block in demuxer.c code below the audio block fixes that and also
> decreases the time spent for demuxing.

hehe
yes, if you remove (or move it after mp3, so it's never reached) mpeg
video demuxer, it won't eat cpu. great. do you wnat to send patch too????

> > it's only called when trying to open the file as mpeg video...
> 
> Well, that's what it does.

yes. and it's good, as mpalyer is a video player, so it should try it as
video first.

> > please stop saying that the demuxer is slow. it is not slow.
> 
> It takes more time to demux an mp3 file than to decode and play it, in 
> my mileage this is damn slow.

bad sentence.
it takes more time to _detect_ an mp3 file than to decode and play it
and it's probably is, because it includes i/o time while playing goes from
cache. anyway, who cares, if detection tooks 0.4 seconds.

mplayer is STILl NOT and mp3 player. it's an unwatned feature, and it won't
be preferred over video playback.
there is strict reason of trying video first, not audio. read the f****
archives, there was already too long thread about it.

and please stop this nonsense thread NOW.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu