[MPlayer-dev-eng] sig11 in -vo x11 - probably bug in SwScaler

[Arpi]

Hi,

> > I've reported it already earlier, that -vo x11 randomly crashes when
> > resizing window (keep pressing key 'f' for few seconds - easiest way to
> > reproduce here).
> pressed for 2 minutes ... no crash :(
hmm.
i'll try to find some trivial and 100% sure way to reproduce it then

> > Now, while tracing a bug in RLE codec, i've got reproducable sig11 again,
> > now with no scaling but in the scaler doing 24->32bpp bgr conversion.
> > It seems that in 24bpp modes it reads more than the allocated image, maybe
> > reads few bytes (lines?) too lot.
> the 24->32 code does allways read 1 byte too much (last bgr is read as 
> 32-bit) but if the width %8 != 0 than it would read more over the end, i can
> fix that but there would be a small performance loss (0.?%) as we must do th
> e 
> last 8 pixels in C, isnt it easier too allocate a larger buffer? and if it 

hmm. is it only fro _src_ image?
i can tweak the vd.c image allocation code to allocate bigger, it is not
problem (just ugly but if it affects the speed - it's ok).
but what is for codecs with own internal buffer allocation (which use
IMGTYPE_EXPORT)? afaik only libmpeg2, odivx libavcodec ars euch, but they
are all yv12.

> reads a line too much than thats a serious bug ...
yes

what happens in yuv2rgb when width or height %2 !=0 ?
width is rare, but i have files where height%2!=0 and they are yv12.
the codecs internally work on 8x8 or 16x16 macroblocks but the display area
(sh->disp_w/h) is smaller, and as it's passed to yuv2rgb dunno what will
happen...


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu