[MPlayer-dev-eng] [PATCH] vo_xv.c (was: Re: [MPlayer-users] Re: KDE & MPlayer)

[D Richard Felker III]

On Sat, May 25, 2002 at 02:58:56AM +0200, Diego Biurrun wrote:
Content-Description: message body text
> D Richard Felker III writes:
>  > On Fri, May 24, 2002 at 02:22:34PM +0200, Diego Biurrun wrote:
>  > > -	mp_msg(MSGT_VO,MSGL_ERR,"Couldn't find free Xvideo port - maybe other applications keep open it.\n"
>  > > +	mp_msg(MSGT_VO,MSGL_ERR,"Could not find free Xvideo port - maybe other applications keep it open.\n"
>  > 
>  > "maybe other applications keep it open" is still bad English usage.
>  > Perhaps something like "maybe another application is already using it"
>  > would be better. Also, IMO process is a much more appropriate word
>  > than application on unix.
> 
> OK, how about this one then:
> 
> 

> --- vo_xv.c	Fri May 24 04:38:49 2002
> +++ vo_xv-diego.c	Sat May 25 02:57:39 2002
> @@ -850,7 +850,7 @@
>      }
>      if(!xv_port){
>        if(busy_ports)
> -	mp_msg(MSGT_VO,MSGL_ERR,"Couldn't find free Xvideo port - maybe other applications keep open it.\n"
> +	mp_msg(MSGT_VO,MSGL_ERR,"Could not find free Xvideo port - maybe another process already uses it.\n"
>  	    "Close all video applications, and try again. If that does not help,\n"
>  	    "see 'mplayer -vo help' for other (non-xv) video out drivers.\n");
>        else

IMO still the same problem. The issue is which type of present tense
you use. You want something like "is using" that indicates present
ongoing action. Although "uses" is present in form, it's very
time-neutral, and has a different sense. For example, if I say "xine
uses xv", that doesn't necessarily mean it has it in use/busy right
now. Rather I would just take it as meaning that xine uses xv when you
run it, or xine is capable of using xv.

Rich