[MPlayer-dev-eng] GUI DXR3 Config patch

[David Holm]

On Saturday 02 November 2002 16.29, Zoltan Ponekker wrote:
> Hali
>
> > > I have rewritten the way the gui handles DXR3 config and added support
> > > for setting TVOut/Overlay.
> > > If the attached patch looks ok I will add support for activating
> > > prebuffering, sync and selecting video output mode (NTSC/PAL).
> > >
> > > Do NOT apply this patch. It changes the way you configure the dxr3 and
> > > I must update the docs first.
> >
> > -#ifdef HAVE_DXR3
> > - if ( !gtkDXR3Device ) gtkDXR3Device=strdup( "/dev/em8300-0" );
> > -#endif
> >
> > why ?
You cannot set the device name based on a string at the moment. It is set as 
an int.
Since it has to open 3 different devices there is no simple way to set it as 
one string, this is easier and cleaner.

>
> + /* These are only used internally to load config */
> + int gtkDXR3Prebuf = 0;
> + int gtkDXR3Sync = 0;
> + int gtkDXR3Overlay = 0;
> + int gtkDXR3Device = 0;
>
> Bad idea, use dxr3 variables (prebuf, sync, overlay ... ), and define the
> variable with unique name. :)
ok, will do

updated patch attached

//David Holm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dxr3gui.patch
Type: text/x-diff
Size: 17420 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20021102/1486b841/attachment.patch>