[MPlayer-dev-eng] [PATCH] remove debug output from unrarlib

[Bernd Ernesti]

Hi,

unrarlib.c creates a debug file, on unix this is /tmp/debug_unrar.txt.
You will find an exmaple of it attached to this mail.

Do we really need this feature?

IMHO it should be disabled by default.

See the attched patch which disables it.

Bernd

-------------- next part --------------
Index: unrarlib.h
===================================================================
RCS file: /cvsroot/mplayer/main/unrarlib.h,v
retrieving revision 1.1
diff -u -r1.1 unrarlib.h
--- unrarlib.h	20 Sep 2002 01:26:39 -0000	1.1
+++ unrarlib.h	2 Nov 2002 17:04:34 -0000
@@ -49,7 +49,7 @@
 /* ************************************************************************ */
 
 
-#define _DEBUG_LOG                          /* generate debug messages      */
+/*#define _DEBUG_LOG*/                      /* generate debug messages      */
 
 #define _DO_CRC32_CHECK                     /* perform cyclical redundancy  */
                                             /* check (CRC32) - disable this */
-------------- next part --------------
Debug log of UniquE's RARFileLib
~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
(executable compiled on Nov  2 2002 at 09:05:38)

        1 ms (line 411 in unrarlib.c):
              - Extracting >[TW]_-_Naruto_Episode_05.ifo< from >[TW]_-_Naruto_Episode_05.rar< (password is ><)...
        1 ms (line 923 in unrarlib.c):
              - Error opening file.
        1 ms (line 454 in unrarlib.c):
              - Error - couldn't extract >[TW]_-_Naruto_Episode_05.ifo< and allocated 0 Bytes of unused memory!
        5 ms (line 411 in unrarlib.c):
              - Extracting >[TW]_-_Naruto_Episode_05.idx< from >[TW]_-_Naruto_Episode_05.rar< (password is ><)...
        5 ms (line 923 in unrarlib.c):
              - Error opening file.
        5 ms (line 454 in unrarlib.c):
              - Error - couldn't extract >[TW]_-_Naruto_Episode_05.idx< and allocated 0 Bytes of unused memory!