[MPlayer-dev-eng] [PATCH] Huge batch of compiler warning fixes
Dominik Mierzejewski
dominik at rangers.eu.org
Mon Nov 4 22:27:16 CET 2002
On Monday, 04 November 2002, Arpi wrote:
> Hi,
>
> > A couple of patches, actually:
> > First one adds -Wall to CFLAGS in places they were missing, so that we
> > can catch all warnings.
>
> _WHY_ ?
Why? To annoy developers into cleaning up their code, for example. :-) I
thought we're almost done with killing all warnings after my previous
patch, but then I noticed that not every Makefile sets -Wall, so I added
it. And boom! Few lines of warnings turned into few hundred. We shouldn't
turn a blind eye on that.
> if someone wants more warnings, then he can add it in config.mak, or set
> own CFLAGS before calling ./configure
I would think a programmer likes to know if his code is standard compliant
or not.
> also i remember that the icc patch removed some of the -Wall's as icc has
> no such option
Has it ever been applied?
--
MPlayer RPMs maintainer: http://www.piorunek.pl/~dominik/linux/pkgs/mplayer/
"The Universe doesn't give you any points for doing things that are easy."
-- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"
More information about the MPlayer-dev-eng
mailing list