[MPlayer-dev-eng] [PATCH] Huge batch of compiler warning fixes

[Dominik Mierzejewski]

On Monday, 04 November 2002, Arpi wrote:
> Hi,
> 
> > > if someone wants more warnings, then he can add it in config.mak, or
> > > set own CFLAGS before calling ./configure
> > 
> > I would think a programmer likes to know if his code is standard
> > compliant or not.
> 
> i can't see any relation between -Wall and std compliance.
> and no, don't ever think of adding -ansi -pedantic too...

:-) I think -ansi is on by default in gcc. I always compile my proggies
with -Wall -pedantic. :->

> i recommend you read the xine-devel list, they did it recently, and
> finally removed, afetr near every developer shouted NO NO NO

:-)

> > > also i remember that the icc patch removed some of the -Wall's as icc
> > > has no such option
> > 
> > Has it ever been applied?
> 
> partially, i applied most parts, including the -g -Wall removing.
> 
> and still, if you really want it, it should be added to the main OPTFLAGS
> to config.mak, instead of every single Makefile.

We could remove it from all Makefiles and add to OPTFLAGS in config.mak.

> but i'm against adding it by default.

And I'm not going to press the issue.

What about the other patch?
 
-- 
MPlayer RPMs maintainer: http://www.piorunek.pl/~dominik/linux/pkgs/mplayer/
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"