[MPlayer-dev-eng] [PATCH] Huge batch of compiler warning fixes

[D Richard Felker III]

On Mon, Nov 04, 2002 at 10:27:16PM +0100, Dominik Mierzejewski wrote:
> On Monday, 04 November 2002, Arpi wrote:
> > Hi,
> > 
> > > A couple of patches, actually:
> > > First one adds -Wall to CFLAGS in places they were missing, so that we
> > > can catch all warnings.
> > 
> > _WHY_ ?
> 
> Why? To annoy developers into cleaning up their code, for example. :-) I
> thought we're almost done with killing all warnings after my previous
> patch, but then I noticed that not every Makefile sets -Wall, so I added
> it. And boom! Few lines of warnings turned into few hundred. We shouldn't
> turn a blind eye on that.

Would you please show me the standard that says it's wrong not to use
one of the arguments to your function? IMHO this is just about the
dumbest possible warning -- many times you have to have unused
arguments so that your function is the right type for passing as a
function pointer. Of course there are many other such nonsense
warnings. IMHO -Wall should always be followed by the options to turn
off particularly dumb warnings, or otherwise you don't notice the real
issues that could be problems because of all the false alarms.

Rich