[MPlayer-dev-eng] [PATCH] Are such changes ok in mplayer.c ?

[Alban Bedel]

Hi D Richard Felker III,

on Tue, 12 Nov 2002 09:48:43 -0500 you wrote:

> On Tue, Nov 12, 2002 at 03:10:30PM +0100, Alban Bedel wrote:
> > 
> > Hi,
> > 
> > I'd like to know if the attached patch is ok. It contain the changes I did in mplayer.c
> > for the osd menus, but it include a very big hunk wich move the command reading
> > and osd update in their own functions. By moving the command reading in his own
> > function (+ a few stuff in the input layer) it's possible to still fully control mplayer
> > in pause and if the osd menus are enabled the osd is even fully working !!
> > These 2 changes aren't really required (I can go without them as all will still work)
> > but I'd like to introduce them as they bring 1 of the most wanted feature. And if i
> > don't add this now i'll go mad about all ppl who will request to be able to use the
> > menus in pause.
> 
> How can this possibly work? The last displayed image isn't saved
> anywhere during pause, so you can't move/remove osd items while it's
> paused... Or did you hack in some trick to stick in a special video
> filter to capture the last frame at pause time??
>
Yes, I did such a hack in the filter used for the menus. So the osd is still alive
only with the osd menus enabled. Such a hack could be done in vf_vo or a
dedicated filter but it's no good idea imho.
	Albeu