[MPlayer-dev-eng] Re: [PATCH] menu problems, again...

[Alban Bedel]

Hi Colin Leroy,

on Thu, 21 Nov 2002 13:20:34 +0100 you wrote:

> On Thu, 21 Nov 2002 22:50:03 +1100 Daniel Pittman <daniel at rimspace.net>
> wrote:
> 
> Hi,
> 
> > > it seems to confirm that's platform dependant.
> > > Could you try with the attached patch ?
> > 
> > That works fine on my system.
> 
> Thanks for the help testing !
I thank you too :)

> So, Albeu, here's the last patch about this:
> - image flags are modified only for powerpc (which is, at now, the only
> platform for which the standard imgflags don't work)
That's very strange bcs MP_IMGFLAG_ACCEPT_STRIDE&MP_IMGFLAG_PREFER_ALIGNED_STRIDE
should be equal to zero. I think that in this case unless you are very lucky it will
only disable DR (dunno really but i doubt you'r video card can accept any stride).
I'm not against appling it but i doubt it's the good solution.
> - mpi isn't fully copied when menu isn't displayed (only pointers are)
This one is ok you can apply it. But keep in mind that when you are using -dr it will
only move the memcpy from vf_menu to vf_vo. I posted a solution wich enable
true DR when the menu aren't show. So it should only make a very little difference
(if any) when the menu are enabled but not shown.
> Please commit, or at least send feedback...
Sorry about that. I really felt guilty for not awnsering your mails, but i'm on 56k atm
so it's not easy to keep up with the list :(
	Albeu