[MPlayer-dev-eng] [PATCH] yet another batch of compiler warning fixes

[Arpi]

Hi,

> > PS. Do you think I could start applying such patches myself directly
> > into CVS? After posting them here for review, of course. 
> IMHO yes, but arpi is the one who must decide that

it's ok.

but please stop sending (and applying) those 'unused variables' patches.
they are there mostly for some uncommented/disabled debug code, and if
you remove them it makes debugging a lot harder.

rather find the right gcc option to hide this kind of warning if you dislike
it.

it's ok to fix other kind of warnings, especially 10l ones (missing return
value, etc).

and i really don't like the default -Wall everywhere.
it's a nightmare to develop code when gcc bombs pages of useless warnings
and it takes minutes to find the real error or important warning messages
there.

if you want to hunt warnings, let's add -Wall, make a patch, but don't force
everyone to read those warnings!


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu