[MPlayer-dev-eng] [PATCH] better handling of lavc's aspect option (was Re: Question about lavcopts's aspect= option)

[Michael Niedermayer]

Hi

On Sunday 24 November 2002 07:33, Gabucino wrote:
> Michael Niedermayer wrote:
> > > With this patch you can do, for example :
> > > mencoder -lavcopts aspect=15/11:...
> >
> > applied with modifications to handle the new float aspect code
>
> Now all the files created with the previous aspect code are wrong.
> 10l
oops, forgot to set the aspect_ratio variable ...
and 100l for alex (storing picture aspect instead of pixel aspect, its fixed 
now too, as AVCodecContext.aspect_ratio is picture aspect but 
aspect_ratio_info means pixel aspect, thats allso why there are several 4/3 
aspect values for aspect ratio info (for 625 & 525 lines))

i dunno how to detect this aspect encoding bug as it was a mencoder/ve_lavc.c 
bug and not a libavcodec one, it cant be detected by the libavcodec build 
value, at least its not correct/clean to detect it by the libavcodec build 
num

btw, the aspect code for mpeg1/2 in video.c looks wrong too

Michael