[MPlayer-dev-eng] New audio filter layer finished

[Anders Johansson]

Hi,

> > put the code in dec_audio. I will have another look at it and send a
> > new patch. If anyone familiar with the code can come up with a better
> > solution please send a patch.
> i'll work on this, hopefully today but more probably only tomorrow.
> i've the code in my mind, just needs to be organized and typed ;)

Thanks!

> > > > If you want to test it apply the patch and try this:
> > > > ./mplayer  -channels 4 -srate 48000  movie.avi
> > > 
> > > btw -srate is a different thing, at leats in mplayer.
> > > it sets teh soundcard's playback rate but it isn't used for a-v calculation,
> > > so using it in filters will confuse a-v sync.
> > 
> > I know that why I had to tinker with o_bps
> > 
> > > we should either change -srate behaviour for mplayer or add a new switch.
> > 
> > I think my usage of -srate is quite intuitive - If you want to have 48kHz
> > playback speed in 4 channels then just give the parameters and the
> > software figures out the details. 
> 
> agree, so we have to add new switch for the old behaviour of -srate
> (changing playback speed)

I am planning to add a switch for selecting playback format as well.

> > > btw 2.
> > > your code seems to use statics for some important context/config storage.
> > > it's ok _now_, but it will make paralell processing of multiple audio tracks
> > > (interesting for mencoder) impossible :(
> > 
> > I didn't think of this, quite easy to change though.
> then change it, please
>
> > > you should introduce a context/handle type parameter for the af API,
> > > pointing to a struct conatining config/etc parameters of teh given audio
> > > stream. i mean something like vf->priv for video filters.
> > 
> > I'll put it on my todo list. 
> ok

Done, attached to this mail is a new diff showing the usage.

> A'rpi / Astral & ESP-team

//Anders
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libaf.diff.gz
Type: application/octet-stream
Size: 1705 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20021001/c7fa3221/attachment.obj>