[MPlayer-dev-eng] [PATCH] -autosync corrected A/V sync

[Sidik Isani]

On Wed, Oct 02, 2002 at 12:10:53AM +0200, Arpi wrote:
> Hi,
> 
> > >   Here's the A/V sync patch.  Please see the description in the part
> > >   of the patch for the man page.  (I put it where -dapsync was, but
> > >   you may want to move it down to the stream options? ... rename the
> > >   option itself? ... whatever you like.)  The important thing is it
> > >   should be evident from the patch that the default, -autosync 0,
> > >   does NOT change the normal sync model of mplayer at all this time!
> > 
> > yes, but it seems that you completely ignore the get_delay() result for
> > autosync!=0, it's bad. it must not be ignored, just smoothened.
> > or is there any hidden sideeffect i didn't notice?
> 
> argh i'm so dumb :)
> 
> didn't notice this:
> 
> +           float difference = delay - predicted;
> +           delay = predicted + difference / (float)autosync;
> 
> so right before kicking out the old value of 'delay' it's used for
> calculating the difference...
> sorry

  No prob.  It is less convoluted than my last attempt but still a
  little tricky, I admit.  Proving that it converges on the proper
  A/V sync value is even more tricky... but it should.  Let's give
  some people the chance to try it this way and see how it works, if
  you're willing.

Be seeing you,

- Sidik