[MPlayer-dev-eng] ANNOUNCE: new audio filter layer in use

[Arpi]

Hi,

> The new af layer is not stable yet, so please test it I want to find
> the bugs. The code is auto-configuring so I think there will be quite a
> lot of issues before it gets stable. Also delay in the filters is not
hmm so maybe we should disable it for 0.90 ?

> 2. Add functionality to enable filters on the command-line (what should
>    the switch be called?). 

-af

also -vop will be renamed to -vf, with reversed filter order :)

> 5. Port form old plugins volume and eq.

ASAP

> Some comments:
> 
> 1. Why did you remove the check for "in <= max_insize"? in
> 
> -  while(in <= max_insize && out <= max_outsize){
> -    if(out > len)
> -      return in;
> -    out = t * (((in/t)*mul.n + 1)/mul.d);
> +  while((out=t * (((in/t+1)*mul.n - 1)/mul.d)) <= max_outsize){
> +    if( (t * (((in/t)*mul.n))/mul.d) >= len) return in;
>      in+=t;
>    }
> ?

argh.. 10l
fixed

> 2. In af_resample I had limited the output frequency to 8kHz cause it
>    is the lowest sample frequency for any type of audio standard that
>    I know of. The filter should work with sample frequencies between 1Hz
>    to 2GHz but, and perhaps it is not up to us to try to control the
>    user? I am however a bit unhappy to set a value below 8kHz cause I
>    would hate to download a movie just to discover that some idiot
>    have down-sampled the sound to 2Khz so that one can't hear what
>    people say. I guess this is a bit of a philosophical question, but
>    who am I to say :)

imho we should handle the technical limits, instead of philosophical ones :)
feel free to change it back, but it was also buggy, it said allowed range is
8k..96k but actually it didn't allow 8k just 8k001 ;)


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu