[MPlayer-dev-eng] [PATCH] set absolute path to fbset in TOOLS/mpconsole

[Diego Biurrun]

On Wed, Oct 09, 2002 at 11:27:04PM -0400, D Richard Felker III wrote:
> On Wed, Oct 09, 2002 at 05:17:56AM +0200, Diego Biurrun wrote:
> > On Tue, Oct 08, 2002 at 10:03:11PM -0400, D Richard Felker III wrote:
> > You are of course right, I was unhappy with hardcoding that path anyway.
> > You can achieve the same effect with a much simpler script nowadays:
> > 
> > setterm -cursor off
> > clear
> > mplayer -vo mga "$@" &> /dev/null
> > setterm -cursor on
> 
> Don't do it this way. The trap is necessary to restore the cursor in
> case the user aborts with ^C, etc. Also &> is questionable; I dunno
> whether it's standard or a bash extension. >/dev/null 2>&1 is
> equivalent and definitely works everywhere.

That was just a quick hack as proof of concept.  I tried &> with ash, it
does not work, so I guess it is a bash extension.  I will avoid it in
the future.

> > Because as you say there is no need to "compute" the dimensions by hand
> > anymore.  But this gets asked over and over again, so it is kind of a
> > shame to let this script go to waste.  If it is really obsolete we
> > should probably remove it entirely.
> 
> IMHO getch2 code in mplayer should disable and enable cursor. Then the
> script would be 100% obsolete.

Definitely.  Any volunteers? :-)

> > > Anyway, if you still want to 'fix' it, try something like:
> > > 
> > > res=`PATH="$PATH:/usr/sbin" fbset | grep geometry | sed 's/^ *//'`
> > 
> > Sounds good, if nobody objects, I will make this change.
> 
> Fine with me.

OK, done.

Diego