[MPlayer-dev-eng] New videofilter: vf_bmovl.c !
Arpi
arpi at thot.banki.hu
Mon Oct 14 00:13:21 CEST 2002
Hi,
> /* vf_bmovl.c v0.9 - BitMap OVerLay videofilter for MPlayer
the code looks ok, but i have some doubts over portability:
> #include <inttypes.h>
> #include <sys/types.h>
afaik sys/types.h is not everywhere available, and anyway inttypes.h
contains the same typedefs and is mandatory anyway for mplayer
(and there is fallback one in etc/inttypes.h)
> int nbytes;
>
> if (ioctl (vf->priv->stream_fd, FIONREAD, &nbytes)) {
> printf ("Got ioctl() error on the FIFO\n");
> perror ("fionread");
> return vf_next_put_image(vf, dmpi);
> }
wtf is this? why don't you use select() or just nonblocking read() and check
its return value?
A'rpi / Astral & ESP-team
--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
More information about the MPlayer-dev-eng
mailing list