[MPlayer-dev-eng] [PATCH] [REPOST] Ericsson phone remote control

[Arpi]

Hi,

> > > Attached is patch that introduce remote control for MPlayer from recent
> > > Ericsson phones with Bluetooth (like T68). Works OK for me, for details 
> > > set up stuff see
> > > http://lyola.com/bte/. Reposting as moderator seems to lose my previous
> > > mail.
> >
> >No offence or anything but this looks awefully like a program that should 
> >be
> >separate from mplayer and pipe through the slave-command protocol, why cant 
> >this
> >be done?
> 
> Probably :), but no uglier that LIRC code that I based on, and which is 
> included
> into main distribution. Anyway it's up to you, I'm not crazy for my patches 
> being applied ;).

Imho it's ok to include such feature/patch into mplayer, this is the purpose
if the input layer. But i don't (really don't) like the fork() in the middle
of your code. MPlayer is a single thread application and forking for input
handler is nonsense, especially by looking at your child process, it can be
done simply without any fork, imho.
So, the patch in this form is refused.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu