[MPlayer-dev-eng] [PATCH] Mach64 vidix register corruption
Michael Niedermayer
michaelni at gmx.at
Tue Oct 22 13:28:39 CEST 2002
Hi
On Monday 21 October 2002 23:45, Colin Leroy wrote:
> Hi,
>
> I noticed that after having played a file with -vo xvidix, there was no
> more image using -vo xv, until X was restarted.
>
> This was due to a corruption of registers. Here's a patch that fixes it :
> it saves regs just after getting video ram parameters, and restores them
> at vixDestroy() time.
> I saved and restored every of them, and didn't touched the code in
> mach64_vid_stop_video() as video can be restarted after a stop (if i
> understood everything).
>
> Hope it's fine,
perhaps yes, perhaps no, i dunno, i dont have any docs of these registers, but
just reading & writing everything in random order might have bad sideeffects,
i would prefer if we could reduce the number of registers written (especially
the control registers, the width/height/coeff stuff shouldnt cause problems)
the reason is that i have seen cases where reading and then writeing the same
value back did cause problems (some old intel chipset, but thats offtopic)
Michael
More information about the MPlayer-dev-eng
mailing list