[MPlayer-dev-eng] [PATCH] Mach64 vidix register corruption

[Arpi]

Hi,

> > I noticed that after having played a file with -vo xvidix, there was no
> > more image using -vo xv, until X was restarted.
> >
> > This was due to a corruption of registers. Here's a patch that fixes it :
> > it saves regs just after getting video ram parameters, and restores them
> > at vixDestroy() time.
> > I saved and restored every of them, and didn't touched the code in
> > mach64_vid_stop_video() as video can be restarted after a stop (if i
> > understood everything).
> >
> > Hope it's fine,
> perhaps yes, perhaps no, i dunno, i dont have any docs of these registers, but 
> just reading & writing everything in random order might have bad sideeffects, 
> i would prefer if we could reduce the number of registers written (especially 
> the control registers, the width/height/coeff stuff shouldnt cause problems)
> the reason is that i have seen cases where reading and then writeing the same 
> value back did cause problems (some old intel chipset, but thats offtopic)

Agree.
for mga_vid, it was enough to save the color key only.
(Xv seems to set colorkey only once at xserver startup - so unless we use
the same colorkey (we don't) we have to restore it to the original value)


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu