[MPlayer-dev-eng] buglets in configure

[Björn Sandell]

On 08 Oct 2002 13:06:29 +0200
gabor <gabor at realtime.sk> wrote:

> On Tue, 2002-10-08 at 12:47, Björn Sandell wrote:
> > 
>
> > I've found some buglets in configure. If I run "./configure
> > --enable-termios" (or, on some archs, "./configure --enable-iconv"; there
> > might be others) compilation (or linking) will fail.
> > 
> > The easy way out of this would be a patch like
> > 
> > @@ -1970,7 +1975,7 @@
> >  
> >  
> >  echocheck "termios"
> > -if test "$_termios" = auto ; then
> > +if test "$_termios" != no ; then
> >    cat > $TMPC <<EOF
> >  #include <sys/termios.h>
> >  int main(void) { return 0; }
> > 
> > but that would make the argument useless. I think that configure should
> > fail if --enable-termios specified and no termios is found. What do you
> > think?
> 
> i don't think so....
> 
> by default it's automatic.... => it detects if you have it or not
> if you force it by --enable-termios..... then you force it..

Then the test should be rewritten as per above (or in some other more clever
way), right?  There not much point in having options that just makes sure that
mplayer won't compile.

-- 
Björn Sandell       DCE/DFS Sysadmin       IT department
Chalmers University of Technology    www.dce.chalmers.se