[MPlayer-dev-eng] release tomorrow (Thursday) ?

[Krister Lagerstrom]

Arpi wrote:
 > Hi,
 >
 > ok we delayed the monday release, so what about it tomorrow? also,
 > we've applied many patches, if not all.
 >
 > are there any non-refused patches out there?
 >
 > are there any major/critical bugs out there?

As mentioned earlier today by Jindrich, libaf/af_resample.c contains a
function gcd() that should be renamed or made static. It breaks
compilation:

./configure --enable-tv-v4l --enable-mga --enable-xmga
--enable-largefiles --disable-lirc --enable-static --disable-alsa
--disable-sdl

make

[snip]

gcc -O4 -march=i686 -mcpu=i686 -pipe -ffast-math -fomit-frame-pointer
-D_REENTRANT -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -Ilibmpdemux
-Iloader -Ilibvo      -o mencoder mencoder.o mp_msg-mencoder.o
cpudetect.o codec-cfg.o cfgparser.o my_profile.o spudec.o playtree.o
playtreeparser.o asxparser.o vobsub.o subreader.o sub_cc.o find_sub.o
unrarlib.o libao2/afmt.o divx4_vbr.o libvo/aclib.o libvo/osd.o
libvo/sub.o libvo/font_load.o libvo/font_load_ft.o xvid_vbr.o
libmpcodecs/libmpencoders.a libmpcodecs/libmpcodecs.a mp3lib/libMP3.a
liba52/liba52.a libmpeg2/libmpeg2.a loader/libloader.a
loader/dshow/libDS_Filter.a libaf/libaf.a libmpdemux/libmpdemux.a
input/libinput.a postproc/libpostproc.a linux/libosdep.a -Llibmpdvdkit2
-lmpdvdkit libavcodec/libavcodec.a  -lmad -lvorbis -logg      -lpng -lz
-static -lz -ljpeg     -lcdda_interface -lcdda_paranoia -lnsl
-lmp3lame -lvorbis -logg   -lpthread -ldl -rdynamic  -lm
/usr/local/lib/libmp3lame.a(util.o): In function `gcd':
util.o(.text+0x24b0): multiple definition of `gcd'
libaf/libaf.a(af_resample.o)(.text+0x760): first defined here
/usr/i486-suse-linux/bin/ld: Warning: size of symbol `gcd' changed from
44 to 26 in util.o
collect2: ld returned 1 exit status
make: *** [mencoder] Error 1


		/ Krister