[MPlayer-dev-eng] [PATCH] afmt.h

[Arpi]

Hi,

> > > soundcard.h is for oss emulation so include it only when USE_OSS_AUDIO is
> > > defined.
> > 
> > why?
> > it's included because it contains the defines of AFMT_ constants.
> > we don't care about being OSS or not here
> 
> If you include soundcard.h on OpenBSD (and NetBSD, I belive) you are
> in OSS-land.

huh? explain plese

> Those lines seems to have ben patched in to make oss work on OpenBSD; see
> http://mplayerhq.hu/pipermail/mplayer-dev-eng/2002-April/007335.html

i can't see the relation
that patch added #ifdef SOUNDCARD_H, and it was ok.

but i can't see why should we check for OSSAUDIO, when the availablity of
soundcard.h is already checked?
and even if OSS support is disabled, we can sue the soundcard.h for defining
the standard AFMT constants.

does this patch fixes any compilation error? i can't imagine, but possible.
or was it just cosmetics?


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu