[MPlayer-dev-eng] [PATCH] First usable version of the new config system
Alban Bedel
albeu at free.fr
Mon Oct 28 11:15:26 CET 2002
Hi Arpi,
on Sat, 26 Oct 2002 19:50:02 +0200 you wrote:
> Hi,
>
> > PS : This patch is only for comments, flame and testing purpose
>
> ok
> first:
>
> +++ main.dev/cfgparser.c Sat Oct 26 18:08:48 2002
> ...
> +#ifndef NEW_CONFIG
> ...
> +#include "libmpdemux/stream.h"
> +#include "playtree.h"
> ...
> +#endif
>
> huh?
> 1. why do you include stream.h there?????
> 2. why do you change code outside of NEW_CONFIG ?
Bcs i removed this include from playtree.h (a function declared there have a
stream_t* arg)thinking that it was better so. I should rather use formard declaration
to properly solve this.
So yes, there is a bit of code modified outside of the #ifdef but it's only to solve dep.
problems betewen the includes.
Attached is a new version. The only 'big' remaining problem is with the x11 vo's
(see my mail $SUBJ = "Potential bug in x11 based drivers ??"). I have 2 way to
solve this : Add a flag to emulate the old config behaviour on some options
(do not reverse them to default unless there were an user setting) or fix x11 vo's
to make sure that the needed vars are correctly set (wich would really solve the
problem). I attached a patch that fix the fullscreen bug and -fixed-vo for xv.
Is it ok this way ?
Albeu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: new_config.diff2
Type: application/octet-stream
Size: 67035 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20021028/446f0f5b/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x11fix.diff
Type: application/octet-stream
Size: 1786 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20021028/446f0f5b/attachment-0001.obj>
More information about the MPlayer-dev-eng
mailing list