[MPlayer-dev-eng] Re: Re: Re: [PATCH] error checking for lavc stats_file writing

Eric Lammerts eric at lammerts.org
Sun Sep 1 14:55:10 CEST 2002


> > imho put_image() should not call exit(), just imaging fprintf()
> > would call exit internally, it would be annoying too ...

Oh, I agree that there are cleaner solutions than mine. I just wanted
to point out that simply ignoring the error is worse than my patch (at
least from a user's point-of-view).

> actually the opening/reading/writing this 2-pass log file should be
> done in mencoder.c instead of ve_*.c, just like for divx4 codec. we
> could kill vpass and use the common -pass option, which already
> implements opening/writing this file.

Unfortunately, I don't have time to implement such things myself,
that's why I came up with a quick&dirty fix.

Eric




More information about the MPlayer-dev-eng mailing list