[MPlayer-dev-eng] Re: [MPlayer-users] Xvidix adds pink stripe on left edge (radeon 8500)

[Emiel Neggers]

Hi,

On Aug 31, 16:01:03 +0200, Diego Biurrun wrote to mplayer-users:
> > > If I use -vo xvidix on my Radeon 8500LE, I get a pink stripe which
> > > is 8 pixels wide on the left hand edge of the overlay window.
> > > [snip]
> > 
> > it's because X_ADJUST is set at 8 in
> > main/vidix/drivers/radeon_vid.c.
> > [snip]
> 
> Could you make a patch out of this and send it to mplayer-dev-eng
> (DOCS/tech/patches.txt has the details)?  Or contact Nick Kurshev at
> mplayerxp, he is the VIDIX maintainer.

Assuming this offset correction was implemented for a reason, there are
Radeon cards that do need this. That would mean that there has to be
made a distinction between different Radeon cards - the ones that need
this correction, and the ones that don't. So far all I know, is that the
Radeon 8500LE cards appear to not need it, and that some other cards do.
Perhaps it's not needed for all Radeon cards based on the R200 core? But
what about the other Radeons (R100, RV100, RV200)?

Stefan Lange actually posted a question about that in this thread, and I
was hoping for an answer. I took a quick look at the mplayerxp source
code for this driver, and even though the driver has undergone some
major upgrades, it looks like Nick hasn't fixed this yet. I'll contact
him about this soon.

If the assumption about the R200 based cards is right, it would be
easiest to simply use the static integer IsR200 which is already there
and replace the X_ADJUST constant with
#define X_ADJUST (IsR200 ? 0 : 8)
At your request I included a patch for that. Apply it if you want to, if
I find out more after having contacted Nick Kurshev I'll let you know.

Regards,
Emiel
-------------- next part --------------
Index: vidix/drivers/radeon_vid.c
===================================================================
RCS file: /cvsroot/mplayer/main/vidix/drivers/radeon_vid.c,v
retrieving revision 1.50
diff -u -r1.50 radeon_vid.c
--- vidix/drivers/radeon_vid.c	9 Jul 2002 10:14:55 -0000	1.50
+++ vidix/drivers/radeon_vid.c	1 Sep 2002 14:20:31 -0000
@@ -23,7 +23,7 @@
 #define X_ADJUST 0
 #else
 #define RADEON_MSG "Radeon_vid:"
-#define X_ADJUST 8
+#define X_ADJUST (IsR200 ? 0 : 8)
 #ifndef RADEON
 #define RADEON
 #endif