[MPlayer-dev-eng] [PATCH] configurable BINDIR and MANDIR; silencing compiler warnings, continued

[Arpi]

Hi,

> > > is a fix of dvdcss_open definitions (makes them consistent everywhere).
> > 
> > could you explain tehse changes in detail? i can't see the reason why do
> > they needed.
> 
> Apart from gcc complaining? It's good to be consistent throughout the sources,
> isn't it?

I've never seen gcc complaining about missing 'const'

> > ^^ added 'const'. why? afaik it only helps optimization by limiting var to
> > readonly.
> 
> That, too. It's also a good practice to set parameter you don't need to modify
> inside a function to const, isn't it?

practices... hey this is not our code, i don't want to make cosmetics, it
has no real use but makes syncing hard.

> > > -dvdcss_handle (*DVDcss_open)  (const char *);
> > > +dvdcss_t      (*DVDcss_open)  (const char *);
> > >  int           (*DVDcss_close) (dvdcss_handle);
> > >  int           (*DVDcss_seek)  (dvdcss_handle, int, int);
> > >  int           (*DVDcss_title) (dvdcss_handle, int); 

>  * Deprecated stuff.

> Only dvd_input.c uses dvdcss_handle. All other files use dvdcss_t,
> so it would appear we can replace all dvdcss_handle with dvdcss_t,
> can't we?
we can, but then do it evrywhere, not just one place.
and again: as we aren't the maintainer of this code, and it doesn't cause
any warning (right?) i can't see why should we change such things.
maybe the next libcss release will fix it and then by syncing it'll be
changed in libmpdvdkit too.

please avoid cosmetics, especialy in libs not written/maintained by us.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu