[PATCH] Re: [MPlayer-dev-eng] Real Time Clock into timer-lx.c?

[Arpi]

Hi,

> +      seteuid(getuid());
> +      /*
> +       * NOTE!  Setting the effective user ID back to the real user
> +       * is the right thing to do here.  Other parts of the code that
> +       * need root privileges still have the option to call seteuid(0)
> +       * when they need it.  (setuid() instead of seteuid() on the other
> +       * hand, would have given up root permanently.)
> +       */

this is not so simple
don't drop root, unless the whole mpalyer code is updated to set it again
when needed... it's just needed at too many places now.
i'm not against such change, but if you change, then do it well, thsi way it
will break everything!


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu