[MPlayer-dev-eng] review of mplayer application

[DINH Viêt Hoà]

I saw some minor problems in mplayer.

1 - playlist with 100000 entries take a long to read, is there any 
description of the philosophy of the playlist (for example, why a tree 
and not a simple list ?) so that I can produce a patch to read it 
faster.


2 - filename is not freed :
in mplayer.c 
  filename = play_tree_iter_get_file(playtree_iter,eof);
the string returned by play_tree_iter_get_file is never freed.

I have some quick fix :
while(playtree_iter != NULL) {
+  if (filename != NULL)
+    free(filename);
  filename = play_tree_iter_get_file(playtree_iter,eof);
  if(filename == NULL) {
    if( play_tree_iter_step(playtree_iter,eof,0) != 
PLAY_TREE_ITER_ENTRY) {
      play_tree_iter_free(playtree_iter);
      playtree_iter = NULL;
    };
  } else
    break;
} 


3 - int get_sub_packet(void)
this function is declared inside another function, which is does not 
conform to C standard.


-- 
DINH V. Hoà - Ingénieur R&D - R&D Engineer - SMARTDIS
30, rue Joseph Bonnet - 33000 Bordeaux - France
Phone : 33 (0) 5 56 32 10 32 - Fax : 33 (0) 5 56 32 00 88
Mobile : 33 (0) 6 32 63 35 56