[MPlayer-dev-eng] [PATCH] MINGW input and others

[Alban Bedel]

Hi Sascha Sommer,

on Wed, 2 Apr 2003 17:30:53 +0200 you wrote:

> Hi, attached is a patch that fixes some issues for the mingw port.
> I'm mainly interest on your comments about the input.c and mplayer.c
> parts. This patch allows to compile input.c without select(), FD_SET
> etc. and changes the keyboard input code to work without select by
> default.
There is just something i can't get. From the patch you just disabled
some parts of input.c wich depend on select. But if there is nothing
avaible from a fd and it will just block, won't it ?

> It also enables fifo code by Arpi which doesn't use pipes.
> I'm not sure if it should be enabled by default or only on systems where
> the current solution doesn't work.
Imvho this should be used only if the actual solution doesn't work.

> Furthermore some parts only needed for cache2 like osdep/shmem.c are put
> into #ifdef USE_STREAM_CACHE
> Please tell me what should be changed before applying.
Look ok for me.
	Albeu