[MPlayer-dev-eng] Cygwin --disable-streaming compilation problem

Diego Biurrun diego at biurrun.de
Sat Apr 19 19:44:02 CEST 2003


Sascha Sommer wrote:
> Can you try with
> #ifndef _FCNTL_H
> #include <fcntl.h>
> #endif
> 
> Afair cygwins gcc 2.5 crashes when including a header 2 times.

Bingo, no more crashes!  3.2 compiles fine with --disable-streaming, 
2.95.3-10 fails as it did before.  A massive improvement!

> If it works we only have to check that  inclusion of fcntl defines _FCNTL_H
> everywhere

fcntl.h contains these two lines:

#ifndef _FCNTL_H
#define _FCNTL_H

So I expect this to be the case.

OK to commit this patch?:

--- libmpdemux/demux_mov.c      2003-03-15 11:52:30.000000000 +0100
+++ ../main/libmpdemux/demux_mov.c      2003-04-19 19:20:55.000000000 +0200
@@ -44,8 +44,7 @@
  #include <zlib.h>
  #endif

-// inclusion of fcntl.h cause cygwin gcc crash
-#ifndef __CYGWIN__
+#ifndef _FCNTL_H
  #include <fcntl.h>
  #endif

Diego





More information about the MPlayer-dev-eng mailing list