[MPlayer-dev-eng] [PATCH] Fix for incorrect URL encoding

Bertrand Baudet bertrand_baudet at yahoo.com
Mon Apr 28 19:04:25 CEST 2003


On Monday 28 April 2003 17:55, Alex Beregszaszi wrote:
> Hi,
>
> > There's a trivial bug in the URL encoding function url_escape_string
> > in libmpdemux. When it finds an octet which needs to be escaped by
> > using the hex form %xx (where xx is the octet in hex notation), it
> > converts digits below 10 correctly but converts 10 to 15 as A+i (where
> > i is 10 to 15) instead of A+i-10. This patch does exactly that. This
> > makes some URLs work (for which the HTTP server would otherwise
> > correctly return 400 Bad Request).
>
> Bertrand, is this a correct fix? Please have a look at it and decide.

Oupps, sorry I forgot about it.
yes the fix look ok to me, and ranma (???) already applied it 10 days ago.
Actually the same should be done for the decoding fonction.

Bertrand



More information about the MPlayer-dev-eng mailing list