[MPlayer-dev-eng] [PATCH] fix for unconditional use of PATH_MAX

[Fabian Franz]

Am Montag, 28. April 2003 19:20 schrieb Robert Millan:
> hi!
>
> code in mplayer.c assumes PATH_MAX is declared, but this is
> wrong since PATH_MAX is not enforced by POSIX, and system
> implementation can choose not to have any limit in the length
> of a path. this breaks build of mplayer on systems that
> don't have PATH_MAX, like GNU (also known as GNU/Hurd).
>
> please apply the attached patch to use dynamical allocation when
> PATH_MAX is not defined.

I'm against this patch.

We had this code before and decided to drop it in favor of PATH_MAX (as 
someone said it was POSIX). To now have it as optional and to make this small 
code so much more complicated is IMHO nonsense.

If you need it, the right fix would imho be to do:

#ifndef PATH_MAX
#define PATH_MAX	SOME_HIGH_VALUE // for example 512, if gnu/hurd can handle 
that, dunno atm.
#endif

cu

Fabian