[MPlayer-dev-eng] [PATCH] fix for unconditional use of PATH_MAX

Alban Bedel albeu at free.fr
Tue Apr 29 09:59:11 CEST 2003


Hi Robert Millan,

on Tue, 29 Apr 2003 09:16:17 +0200 you wrote:

> On Mon, Apr 28, 2003 at 07:49:32PM +0200, Fabian Franz wrote:
> > 
> > I'm against this patch.
> > 
> > We had this code before and decided to drop it in favor of PATH_MAX
> > (as someone said it was POSIX). To now have it as optional and to make
> > this small code so much more complicated is IMHO nonsense.
> > 
> > If you need it, the right fix would imho be to do:
> > 
> > #ifndef PATH_MAX
> > #define PATH_MAX	SOME_HIGH_VALUE // for example 512, if gnu/hurd can handle
> > #
> > that, dunno atm.
> > #endif
> 
> POSIX describes PATH_MAX, but it is left optional to implementors wether
> it is defined or not.(I can search you the exact quote if you need it)
Then we should use dynamic alloc for all. Imho there not much sense in
having 2 differents implementations for this.
	Albeu



More information about the MPlayer-dev-eng mailing list