[MPlayer-dev-eng] [PATCH] Latest CVS Theora update and about Tremor 2

[Martin Drab]

On Mon, 18 Aug 2003, Martin Drab wrote:

> On Mon, 18 Aug 2003, The Wanderer wrote:
> 
> > Alex Beregszaszi wrote:
> > > Hi,
> > > 
> > > Applied with minor changes in configure.
> > 
> > Compiling this works for me only up through the point where the output
> > file 'mplayer' would actually be created. At that point I still get
> > numerous "undefined reference" errors in various parts of libtheora.a.
> > All of them seem to be complaining about 'oggpackB_foo', where 'foo' is
> > any of 'read', 'write', 'bytes', 'readinit', 'writeinit', 'get_buffer',
> > or 'reset'.
> > 
> > This is almost certainly not the result of another change in libtheora,
> > as when I updated it from CVS immediately before configuring there were
> > no reported changes. I'm not sure where the problem might be, and have
> > not yet the experience to have an idea where to start looking, but I
> > wanted to report this anyway.
> > 
> > Further information, such as I have, can be provided on request - I'm
> > currently recompiling from scratch to create a message log.
> 
> My guess is, that you havent enabled Vorbis! Unfortunately (as I wrote 
> earlier) the whole OGG/Vorbis/Tremor/Theora thing is not very well 
> written. Problem is, that libtheora library also depends on libogg :-(.
> 
> Attached is a patch, that makes link libogg when only Theora is enabled 
> without Vorbis. So with it there is no need to enable Vorbis any more.

Whoops! A little mistake again! :-( I forgot the "test" word in my 
previous patch. So this one is corrected.

Martin

-------------- next part --------------
diff -Naur old/configure new/configure
--- old/configure	2003-08-18 16:24:29.000000000 +0200
+++ new/configure	2003-08-18 18:55:35.000000000 +0200
@@ -4214,7 +4214,11 @@
 if test "$_theora" = yes ; then
   _def_theora='#define HAVE_OGGTHEORA 1'
   _codecmodules="libtheora $_codecmodules"
-  _ld_theora="-ltheora"
+  if test "$_vorbis" = no ; then
+    _ld_theora="-ltheora -logg"
+  else
+    _ld_theora="-ltheora"
+  fi
 else
   _def_theora='#undef HAVE_OGGTHEORA'
   _nocodecmodules="libtheora $_nocodecmodules"