[MPlayer-dev-eng] [PATCH] dvb fix

[David Kuehling]

Hi,

I just checked out the latest version (all of your patches were commited
to CVS, no?), and am still having trouble.  One of the bugs I already
tracked down:

if channels.conf contains empty lines, dvbin.c still reads that line via
sscanf and creates a channel with freq=0.  When seeking to such a
"channel", mplayer endlessly displays

dvb_streaming_read, attempt N. 5 failed with errno 11 when reading 2048 bytes
dvb_streaming_read, attempt N. 4 failed with errno 11 when reading 2048 bytes
dvb_streaming_read, attempt N. 3 failed with errno 11 when reading 2048 bytes
dvb_streaming_read, attempt N. 2 failed with errno 11 when reading 2048 bytes
dvb_streaming_read, attempt N. 1 failed with errno 11 when reading 2048 bytes
dvb_streaming_read, return 0 bytes

Ok, I fixed my channels.conf, but still I think should you do some error
checking when reading it.  You should check `fields' returned from
sscanf, and whether channel options like freq are within sane ranges.
Would be very helpful if you output some errors, I had to read through
your code to find out what was wrong...

I did those tests with

mplayer dvb://<channel> -vfm ffmpeg -nosound

I still get A/V sync problems when enabling sound, making audio
disappear after 15-20 seconds.  Zapping doesn't also work with "-cache
4096".  When zapping quickly after startup/zapping, the cache is
replayed and at the end mplayer exits.  When waiting long time before
zapping, it works, but zapping is much slower with -cache than without
(taking up to 10 seconds).


mplayer dvb://<channel> -vfm ffmpeg -nosound -cache 4096 
<after zapping>

dvb_streaming_read, attempt N. 5 failed with errno 11 when reading 1048 bytes
dvb_streaming_read, attempt N. 4 failed with errno 11 when reading 1048 bytes
dvb_streaming_read, attempt N. 3 failed with errno 11 when reading 1048 bytes
dvb_streaming_read, attempt N. 2 failed with errno 11 when reading 1048 bytes
dvb_streaming_read, attempt N. 1 failed with errno 11 when reading 1048 bytes
dvb_streaming_read, attempt N. 5 failed with errno 11 when reading 2048 bytes
dvb_streaming_read, attempt N. 4 failed with errno 11 when reading 2048 bytes
dvb_streaming_read, attempt N. 3 failed with errno 11 when reading 2048 bytes
dvb_streaming_read, attempt N. 2 failed with errno 11 when reading 2048 bytes
dvb_streaming_read, attempt N. 1 failed with errno 11 when reading 2048 bytes
dvb_streaming_read, return 0 bytes
Successfully enabled DPMS
UNINIT COMPLETE
TS file format detected.
PROBING UP TO 2000000, PROG: 0
...

mplayer dvb://<channel> -vfm ffmpeg -nosound
<after zapping>

dvb_streaming_read, attempt N. 1 failed with errno 11 when reading 716 bytes
dvb_streaming_read, attempt N. 1 failed with errno 11 when reading 2048 bytes
dvb_streaming_read, return 0 bytes
Successfully enabled DPMS
UNINIT COMPLETE
TS file format detected.
PROBING UP TO 2000000, PROG: 0
...

That's not coincidence, checked it many times with different channels.

Unfortunately I'm not at work today and cannot do any uploads.  But
being sick and staying home, gives me lots of time to tinker around with
your DVB code :-)

David
-- 
GnuPG public key: http://user.cs.tu-berlin.de/~dvdkhlng/dk.gpg
Fingerprint: B17A DC95 D293 657B 4205  D016 7DEF 5323 C174 7D40