[MPlayer-dev-eng] Re: [PATCH] Incomplete patch for USF (correct diff) NOVIRUS

[Joey Parrish]

On Wed, Dec 10, 2003 at 04:38:22PM +0100, Attila Kinali wrote:
> On Wed, 10 Dec 2003 09:35:32 -0600
> Joey Parrish <joey at nicewarrior.org> wrote:
> 
> > On Wed, Dec 10, 2003 at 09:27:54AM +0100, Moritz Bunkus wrote:
> > > +	if (!sscanf(line, " <subtitle start=\"%d:%d:%d.%d\" stop=\"%d:%d:%d.%d\"", &a1, &a2, &a3, &a4, &b1, &b2, &b3, &b4)) {
> > > 
> > > sscanf returns the number of items assigned, so you should better test
> > > for 'sscanf(...) != 8'.
> > that's the same thing.  if (!x) vs if (x != 0).
> 
> but != 0 is not the same as != 8

I'm all kinds of wrong.  if (x != 0) vs if (x) is what i should have
been saying, and even then it's not what everyone else is talking about.
:)

Forgive me, please.  I'm using a crappy TV as a terminal, and I don't
have my glasses on.  It's hard to see that 0 != 8.  :)

Is there a soda policy for screwing up mail?

--Joey

-- 
"Living in the complex world of the future is somewhat
like having bees live in your head.  But, there they are."