[MPlayer-dev-eng] [PATCH] fontconfig configure bug

Matthew Fischer futhark at vzavenue.net
Wed Dec 17 05:11:26 CET 2003


MPlayer's configure fails to detect fontconfig on a system with
POSIXLY_CORRECT set in the environment. The reason it fails is that it
passes the arguments to pkg-config in the wrong order. (When
POSIXLY_CORRECT is not set, glibc takes the liberty of rearranging the
parameters.)

The attached patch fixes things.

--- MPlayer-1.0pre3/configure.orig	2003-12-08 15:33:31.000000000 -0600
+++ MPlayer-1.0pre3/configure	2003-12-09 18:17:03.000000000 -0600
@@ -4252,7 +4252,7 @@
 fi
 echocheck "fontconfig"
 if test "$_fontconfig" = auto ; then
-    if ( pkg-config fontconfig --modversion) > /dev/null 2>&1 ; then
+    if ( pkg-config --modversion fontconfig) > /dev/null 2>&1 ; then
         cat > $TMPC << EOF
 #include <stdio.h>
 #include <fontconfig/fontconfig.h>
@@ -4268,15 +4268,15 @@
 }
 EOF
         _fontconfig=no
-        cc_check `pkg-config fontconfig --cflags --libs` && ( $TMPO >> "$TMPLOG" ) && _fontconfig=yes
+        cc_check `pkg-config --cflags --libs fontconfig` && ( $TMPO >> "$TMPLOG" ) && _fontconfig=yes
     else
         _fontconfig=no
     fi
 fi
 if test "$_fontconfig" = yes ; then
     _def_fontconfig='#define HAVE_FONTCONFIG'
-    _inc_fontconfig=`pkg-config fontconfig --cflags`
-    _ld_fontconfig=`pkg-config fontconfig --libs`
+    _inc_fontconfig=`pkg-config --cflags fontconfig`
+    _ld_fontconfig=`pkg-config --libs fontconfig`
 else
     _def_fontconfig='#undef HAVE_FONTCONFIG'
 fi



More information about the MPlayer-dev-eng mailing list