[MPlayer-dev-eng] [PATCH] (UPDATE) playback speed, set memory point, back memory point

[Diego Biurrun]

Belousov Oleg writes:
 > This patch allows to change speed of playback dynamically (bind
 > "speed" in file input_conf). And also to remember a place of file
 > ("set_memory") and quickly to come back to it ("seek_memory")

These are two different things that appear to be independent in your
patch, so please send two different patches.  This will make reviewing
and accepting rejecting easier.

 > --- etc/input.conf	30 Nov 2003 16:36:05 -0000	1.11
 > +++ etc/input.conf	26 Dec 2003 09:16:11 -0000
 > @@ -7,6 +7,11 @@
 >  ## The file should be placed in the $HOME/.mplayer directory.
 >  ##
 >  
 > +a speed -0.25
 > +s speed 0.25
 > +m set_memory
 > +b seek_memory

You cannot "hijack" keys.  Use some keys that are not yet used.

 > --- input/input.c	30 Nov 2003 16:36:07 -0000	1.87
 > +++ input/input.c	26 Dec 2003 09:16:12 -0000
 > @@ -55,7 +55,10 @@
 >    { MP_CMD_EDL_MARK, "edl_mark", 0, { {-1,{0}} } },
 >  #endif
 >    { MP_CMD_AUDIO_DELAY, "audio_delay", 1, { {MP_CMD_ARG_FLOAT,{0}}, {-1,{0}} } },
 > +  { MP_CMD_SET_SPEED, "speed", 1, { {MP_CMD_ARG_FLOAT,{0}}, {-1,{0}} } },
 >    { MP_CMD_QUIT, "quit", 0, { {-1,{0}} } },
 > +  { MP_CMD_SET_MEMORY, "set_memory", 0, { {-1,{0}} } },
 > +  { MP_CMD_SEEK_MEMORY, "seek_memory", 0, { {-1,{0}} } },

Please add a description of these new commands to DOCS/tech/slave.txt.

Diego