[MPlayer-dev-eng] [PATCH] Trivial fix for nv12 swapped chroma

Arpi arpi at thot.banki.hu
Sun Dec 28 11:57:52 CET 2003


> > Hauppauge nv12 video results in a picture which has blue and
> > red swapped.  The code currently swaps the destination planes
> > if "swapped" is set which is confusing since DOCS/tech/colorspaces.txt
> > says:
> > 
> >   Note: planes[1] is ALWAYS U, and planes[2] is V
> > 
> > Also "swapped" is currently set if the format is nv12 which is
> > confusing since nv12 stores the U and V in the same order as hm12
> > which doesn't swap the bytes.
> > 
> > This patch simply swaps the source (instead of the destination) if
> > "swapped" is set and only sets "swapped" if the format is nv21. MPlayer
> > plays the video fine after this patch is applied.
> What about this patch ?
> Although i dont fully understand this part of the code, the
> patch makes sense regarding the documentation.

looked ok to me, i even said alex to commit it, but he didnt

A'rpi / Astral & ESP-team

Developer of MPlayer G2, the Movie Framework for all - http://www.MPlayerHQ.hu

More information about the MPlayer-dev-eng mailing list