[MPlayer-dev-eng] [PATCH] GIF support, release quality?

Alex Beregszaszi alex at naxine.org
Mon Feb 3 19:30:09 CET 2003


Hi,

> btw, IMHO, we should either document such hacks (like palette in the
> 2nd plane) or use a descriptive name like palete, IMHO the later is
> much better as all code which uses mp_image_t is much more readable
> then (img.plane[1] vs. img.palete) everyone knows what the 2nd one
> means, but only 3 or 4 ppl might know that plane[1] is the palete ...
yes, and we are the 'selected' ones ;)

btw, it should be documented (before 0.90) that plane[1] could be used
as a palette, and _only after 0.90_ we could add the palette entry into
mpi. (I had the same idea as you, but finally Arpi and I decided to do
not extend it, as the palette support was broken that times anyway)

-- 
Alex Beregszaszi  <alex at naxine.org>
(MPlayer Core Developer -- http://www.mplayerhq.hu/)
  ZDNet.au: "Where do you see Linux in 5 years?"
  Alan Cox: "Hopefully world domination! (laughs)."


More information about the MPlayer-dev-eng mailing list